[DONTMERGE] Unity chan

[sindharta]

No description provided.

[tigran-sargsyan-w]

PR Review – [DONTMERGE] Unity chan (#592)

Summary
Thanks for putting this together — this PR introduces a full UnityChan URP sample that nicely showcases Toon Shader with animation, wind and UI tooling.

What looks good

• Clear folder structure under Samples~/URP/UnityChan with Common/SD split.
• Reuse of existing tooling (SpringManager, animation previewers, etc.) instead of ad‑hoc code.
• Integration with the new Input System to drive the sample.

Suggestions / questions

1. PR size & scope – This is a very large change (+11k / −4.8k, 238 files) that mixes scripts, binary assets, project settings and test project updates. If possible, consider splitting into:

   • one PR for the sample content itself (scenes, prefabs, scripts),
   • another for test project / ProjectSettings changes.

2. Licensing / credits – Since UnityChan assets come with their own license/attribution requirements, it would be good to:

   • add a short README.md in the sample folder explaining the license,
   • include links to the original UnityChan terms and any required credits.

3. Dependencies – The sample appears to rely on the Input System package. It might help to:

   • explicitly document this in a sample README,
   • ensure the sample asmdef (if any) marks com.unity.inputsystem as a dependency so users don’t hit missing‑package errors.

4. Namespacing – Some of the newly added scripts likely live in a fairly generic namespace or the global scope. To avoid clashes in user projects, consider putting them under a more specific namespace (for example Unity.ToonShader.Samples.UnityChan).

5. Docs / onboarding – A short “Getting started” section (open ToonShader.unity, how to toggle preview UI, input bindings, etc.) would make it much easier for users to explore the sample.

Overall, this looks like a very cool demo of Toon Shader in a real character scenario — with a bit of trimming and documentation it should be much easier to review and ship.

[sindharta-tanuwijaya]

Hi,

Thank you very much for your review—I really appreciate it.

You’re right that this PR is quite large and it may still grow. I like your suggestion to split it into smaller chunks, and I’ll follow that whenever possible.

2. Licensing / credits – Since UnityChan assets come with their own license/attribution requirements,

You’re correct; we should have included them earlier.

Regarding the sample: it doesn’t strictly depend on the input system package. You can remove that package and the sample should still work.

• Namespacing
• Docs / onboarding

The sample was taken directly from the Unity-chan website

Given that, your feedback will be valuable for us to consider when we update the version hosted on that site.
Thank you again.