Fix Swagger lockdown, TestComponent removal, focus/contrast coverage, NFT reward tests - #396
Merged
dzekojohn4 merged 2 commits intoAug 31, 2026
Conversation
… NFT reward tests - UnityChainxx#312: Gate Swagger (/docs) behind app config so it stays disabled in production unless explicitly enabled; strip internal detail via operationIdFactory. Only mounted when the environment allows it. - UnityChainxx#337: Remove unused frontend/components/TestComponent.jsx (fetched JSONPlaceholder in a client component) and add a guard test that keeps the external test request out of the production source tree. - UnityChainxx#324: Add a base :focus-visible indicator for all interactive controls plus brand color tokens; improve Pagination focus states and dark-theme secondary text contrast in PuzzleComponent. - UnityChainxx#355: Fix the broken duplicate-mint test in stellar_hunts_nft so the crate's test suite compiles and covers the NFT reward flow. Closes UnityChainxx#312 Closes UnityChainxx#324 Closes UnityChainxx#337 Closes UnityChainxx#355
|
@solomon35-stack Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
dzekojohn4
approved these changes
Aug 31, 2026
dzekojohn4
left a comment
dzekojohn4
left a comment
Contributor
There was a problem hiding this comment.
Looks good, merging in.
dzekojohn4
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #312
Closes #324
Closes #337
Closes #355
What changed
/docsis only mounted when the environment allows it; 404 in prod/staging unlessSWAGGER_ENABLED=true.jsonplaceholder.typicode.comand adds a guard test keeping the external request out of the production source tree.:focus-visiblering, brand color tokens, Pagination focus states, dark-theme secondary text contrast.Verification
jsonplaceholderinsidetests/, which its own walker skips.test_double_mint_rejectednow exercises the real reject-on-second-mint path.Note: deps aren't installed and
cargois unavailable in this workspace, so runners weren't executed; logic verified by inspection.