fix: detect nullable allOf type conflicts - #58
Open
FanouZeng-TT wants to merge 1 commit into
Open
Conversation
damaz91
approved these changes
Aug 17, 2026
carolinerg1
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
validate_allof_typesonly compared string-formtypekeywords. An array-form type such as["string", "null"]was skipped, so combining it with"number"in anotherallOfbranch passed resolution even though no JSON instance can satisfy both branches.Fix: normalize string and array forms into accepted JSON instance-type sets and intersect them across matching properties. Empty intersections keep returning the existing
TypeConflict; overlapping nullable types and the JSON Schemanumber/integerrelationship remain valid.The regression test covers all three boundaries:
["string", "null"]with"number"reports a conflict["string", "null"]with"string"resolves"number"with"integer"resolvesCategory (Required)
Related Issues
N/A
Checklist
generate_models.shunderpython_sdk(not applicable).Screenshots / Logs (if applicable)
N/A — verified with
cargo test --all-targets,cargo clippy --all-targets -- -D warnings,cargo fmt --check, and all pre-commit hooks.