fix: skip annotation checks in instance data - #61
Closed
FanouZeng-TT wants to merge 1 commit into
Closed
Conversation
damaz91
approved these changes
Aug 18, 2026
carolinerg1
approved these changes
Aug 20, 2026
17 tasks
Contributor
|
Thanks @FanouZeng-TT. #66 landed this guard centrally — To be clear about scope: only the annotation check is covered. The Closing this one as fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
check_annotationscurrently walks every object and array value in a schema. JSON Schema keywords such asdefault,const,examples, andenumcontain instance data rather than child schemas, so payload fields nameducp_requestorucp_responseinside those values can be misreported as invalid UCP annotations.This change skips those instance-data keywords during annotation traversal while preserving validation for real schema locations. It also adds a regression test covering annotation-like field names inside
default,const,examples, andenum.Category (Required)
Related Issues
None.
Checklist
Screenshots / Logs (if applicable)
cargo test --manifest-path /Users/bytedance/All/UCP/PR记录/worktrees/71-ucp-schema/Cargo.toml --all-targetscargo clippy --manifest-path /Users/bytedance/All/UCP/PR记录/worktrees/71-ucp-schema/Cargo.toml --all-targets -- -D warningscargo fmt --manifest-path /Users/bytedance/All/UCP/PR记录/worktrees/71-ucp-schema/Cargo.toml -- --checkuvx pre-commit run --all-files --show-diff-on-failuregit diff --check