Skip to content

pkg(com.samsung.android.dynamiclock) Breaks LockStar customizations #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Rudxain merged 1 commit into from
Nov 25, 2024
Merged

pkg(com.samsung.android.dynamiclock) Breaks LockStar customizations #734

Rudxain merged 1 commit into from
Nov 25, 2024

Conversation

@schbrns
Copy link
Member

@schbrns schbrns commented Nov 25, 2024

No description provided.

@schbrns schbrns added the package::breakage Phone has unexpected issues after debloating label Nov 25, 2024
@schbrns schbrns self-assigned this Nov 25, 2024
@schbrns schbrns linked an issue Nov 25, 2024 that may be closed by this pull request
pkg(scope): Removing wallpaper services breaks Lock Star #613
Closed
3 tasks
Rudxain
Rudxain approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@Rudxain Rudxain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I'm unsure if it should be changed to Advanced, as it's just customization

@schbrns
Copy link
Member Author

schbrns commented Nov 25, 2024

LGTM. But I'm unsure if it should be changed to Advanced, as it's just customization

Sorry I forgot to leave justification.
I set it to advanced because it breaks functionality for extended UI features.
I'm keeping the docs in mind but also generally going with:
Does it break functionality? Yes -> Advanced
Does it break core functionality? Yes -> Expert

@schbrns schbrns changed the title scope(com.samsung.android.dynamiclock) Breaks LockStar customizations pkg(com.samsung.android.dynamiclock) Breaks LockStar customizations Nov 25, 2024
@schbrns schbrns removed their assignment Nov 25, 2024
@Rudxain Rudxain merged commit 5fa7a0e into main Nov 25, 2024
12 of 18 checks passed
@Rudxain Rudxain deleted the 613-pkgscope-removing-wallpaper-services-breaks-lock-star branch November 25, 2024 07:02
@AnonymousWP AnonymousWP added package::documentation Improve a description/recommendation and removed package::breakage Phone has unexpected issues after debloating labels Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rudxain Rudxain Rudxain approved these changes

@AnonymousWP AnonymousWP Awaiting requested review from AnonymousWP

Assignees

No one assigned

Labels

package::documentation Improve a description/recommendation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pkg(scope): Removing wallpaper services breaks Lock Star

4 participants

@schbrns @Rudxain @AnonymousWP