Skip to content

Conversation

@Rudxain
Copy link
Member

@Rudxain Rudxain commented Apr 29, 2025

Closes #623

I've only reviewed a few deps. I've cargo run and the app seems to work fine.

Iced-0.13 would require a big rewrite (IMO, it was overdue anyways), but there are bugs (such as #432) and QoL improvements (for users and devs) that would be resolved by it.

We should also update flake.lock: #622 (comment)

@Rudxain Rudxain added the dependencies Pull requests that update a dependency file label Apr 29, 2025
@AnonymousWP AnonymousWP changed the title chore(deps): Upgrade dependencies chore(deps): upgrade dependencies Apr 29, 2025
@AnonymousWP AnonymousWP changed the title chore(deps): upgrade dependencies build(deps): upgrade dependencies Apr 30, 2025
@Rudxain Rudxain force-pushed the chore/deps/bump branch from 3246407 to 36c997a Compare May 1, 2025 03:17
@Rudxain Rudxain force-pushed the chore/deps/bump branch from 36c997a to 1c60270 Compare May 15, 2025 03:06
@Rudxain Rudxain force-pushed the chore/deps/bump branch 2 times, most recently from e8c4564 to e499a54 Compare May 26, 2025 19:46
@Rudxain Rudxain force-pushed the chore/deps/bump branch from e499a54 to 244e035 Compare June 8, 2025 20:17
@Rudxain Rudxain force-pushed the chore/deps/bump branch 2 times, most recently from 731fb2f to 9ff5d6b Compare June 28, 2025 04:40
@Rudxain Rudxain force-pushed the chore/deps/bump branch 3 times, most recently from d0e0317 to ea99051 Compare July 5, 2025 22:22
@Rudxain Rudxain marked this pull request as ready for review July 5, 2025 22:33
@Rudxain Rudxain requested a review from a team July 5, 2025 22:45
@AnonymousWP

This comment was marked as resolved.

@Rudxain

This comment was marked as resolved.

@Rudxain Rudxain closed this Jul 6, 2025
@Rudxain Rudxain reopened this Jul 6, 2025
@Rudxain

This comment was marked as resolved.

@Rudxain

This comment was marked as resolved.

@Rudxain

This comment was marked as outdated.

@Rudxain

This comment was marked as outdated.

@Rudxain
Copy link
Member Author

Rudxain commented Jul 6, 2025

If anyone has Windows, we'd appreciate if you tested embed-resource, because it's only used on that OS

@Rudxain

This comment was marked as resolved.

@Rudxain Rudxain marked this pull request as draft July 6, 2025 07:43
@Rudxain Rudxain force-pushed the chore/deps/bump branch 2 times, most recently from fbe828b to f9e646c Compare July 6, 2025 08:07
@Rudxain Rudxain marked this pull request as ready for review July 6, 2025 08:07
@Rudxain Rudxain force-pushed the chore/deps/bump branch from f9e646c to 2df9e4c Compare July 6, 2025 08:11
@Rudxain Rudxain changed the title build(deps): upgrade dependencies build(deps): upgrade all dependencies but Iced Jul 6, 2025
Copy link
Member

@AnonymousWP AnonymousWP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Artifacts: https://github.com/Universal-Debloater-Alliance/universal-android-debloater-next-generation/actions/runs/16404011996. Seems to work fine on Windows.

Doesn't work on both Debian 12.11 and AlmaLinux 9 while other apps do. WSL2 by the way. Output:

./uad-ng-linux

thread 'main' panicked at /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/iced_winit-0.12.2/src/application.rs:119:10:
Create event loop: Os(OsError { line: 80, file: "/home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/winit-0.29.15/src/platform_impl/linux/wayland/event_loop/mod.rs", error: WaylandError(Connection(NoCompositor)) })
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Does it work on your machine?

@Rudxain
Copy link
Member Author

Rudxain commented Jul 21, 2025

thread 'main' panicked at /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/iced_winit-0.12.2/src/application.rs:119:10:
Create event loop: Os(OsError { line: 80, file: "/home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/winit-0.29.15/src/platform_impl/linux/wayland/event_loop/mod.rs", error: WaylandError(Connection(NoCompositor)) })
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

That's odd...

Does it work on your machine?

I've downloaded uad-ng-noselfupdate-linux (the download failed too many times), and it works on my install 😕

@AnonymousWP
Copy link
Member

AnonymousWP commented Jul 21, 2025

thread 'main' panicked at /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/iced_winit-0.12.2/src/application.rs:119:10:
Create event loop: Os(OsError { line: 80, file: "/home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/winit-0.29.15/src/platform_impl/linux/wayland/event_loop/mod.rs", error: WaylandError(Connection(NoCompositor)) })
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

That's odd...

Does it work on your machine?

I've downloaded uad-ng-noselfupdate-linux (the download failed too many times), and it works on my install 😕

I tried the 'regular' one, i.e. without noselfupdate.

I think it's safe to say to merge because it works on both platforms?

@Rudxain
Copy link
Member Author

Rudxain commented Jul 21, 2025

What if we generate artifacts for main to do a comparison? If it fails there, then it's something else causing the failure

@AnonymousWP
Copy link
Member

AnonymousWP commented Jul 21, 2025

What if we generate artifacts for main to do a comparison? If it fails there, then it's something else causing the failure

Sure, go ahead. I'll also test on my end.

@AnonymousWP
Copy link
Member

@AnonymousWP
Copy link
Member

Same issue on Debian and AlmaLinux when I use the one from main (see runner above) and even when using the latest current release (1.1.2). Probably a Debian and AL issue then.

@Rudxain
Copy link
Member Author

Rudxain commented Jul 22, 2025

https://github.com/Universal-Debloater-Alliance/universal-android-debloater-next-generation/actions/runs/16439565312

It also works on my PC

Same issue on Debian and AlmaLinux when I use the one from main (see runner above) and even when using the latest current release (1.1.2)

Ok then I'll merge

@Rudxain Rudxain merged commit b34492e into main Jul 22, 2025
23 checks passed
@Rudxain Rudxain deleted the chore/deps/bump branch July 22, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build(deps): bump dependencies

3 participants