-
Notifications
You must be signed in to change notification settings - Fork 227
build(deps): upgrade all dependencies but Iced #949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5e3c543 to
3246407
Compare
e8c4564 to
e499a54
Compare
731fb2f to
9ff5d6b
Compare
d0e0317 to
ea99051
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
If anyone has Windows, we'd appreciate if you tested |
This comment was marked as resolved.
This comment was marked as resolved.
fbe828b to
f9e646c
Compare
2df9e4c to
be13905
Compare
AnonymousWP
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Artifacts: https://github.com/Universal-Debloater-Alliance/universal-android-debloater-next-generation/actions/runs/16404011996. Seems to work fine on Windows.
Doesn't work on both Debian 12.11 and AlmaLinux 9 while other apps do. WSL2 by the way. Output:
./uad-ng-linux
thread 'main' panicked at /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/iced_winit-0.12.2/src/application.rs:119:10:
Create event loop: Os(OsError { line: 80, file: "/home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/winit-0.29.15/src/platform_impl/linux/wayland/event_loop/mod.rs", error: WaylandError(Connection(NoCompositor)) })
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Does it work on your machine?
That's odd...
I've downloaded |
I tried the 'regular' one, i.e. without I think it's safe to say to merge because it works on both platforms? |
|
What if we generate artifacts for |
Sure, go ahead. I'll also test on my end. |
|
Same issue on Debian and AlmaLinux when I use the one from main (see runner above) and even when using the latest current release (1.1.2). Probably a Debian and AL issue then. |
|
It also works on my PC
Ok then I'll merge |
Closes #623
I've only reviewed a few deps. I've
cargo runand the app seems to work fine.Iced-0.13 would require a big rewrite (IMO, it was overdue anyways), but there are bugs (such as #432) and QoL improvements (for users and devs) that would be resolved by it.
We should also update
flake.lock: #622 (comment)