-
-
Notifications
You must be signed in to change notification settings - Fork 202
Adds iiif av component back into main application #1495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds iiif av component back into main application #1495
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@K8Sewell, Thanks for the PR! I’ve done a round of testing and wanted to share my findings. Hopefully these details are useful and of course, I’d be glad if others could also take a look and confirm. Layout comparison Dev (audio/video viewer):
0penSeadragon manifest Layout PR #1495 (audio/video viewer):
0penSeadragon manifest Layout screenshots comparison for the layout: Manifest loading issues
Other issues:
dev screenshot Additional observations
In this manifest, the images in the content panel differ from dev:
Thanks again for working on this PR! I really appreciate the effort, and I’ll be happy to retest once updates are made. |
|
Thanks for the testing, @LanieOkorodudu -- something strange is definitely going on here. I can think of no reason why integrating the AV component should change anything outside of the AV component, but somehow certain manifests no longer load correctly, and default behaviors of other modules are different. I think further investigation will be needed! Unfortunately, as I mentioned on the last call, I am currently overwhelmed with work in other projects, so I am probably not going to be able to look more closely at this for some time. I wish I had more bandwidth, but I simply don't at the moment. I will try to revisit this when possible, though! |
|
Closing in favor of #1549 |








Summary
Returns the IIIF AV Component back into main UV application. Post returning the component some styling was needed to adjust the footer panel and lower tabs.
Related Ticket
#1380