Skip to content

Conversation

@K8Sewell
Copy link
Contributor

@K8Sewell K8Sewell commented Jul 8, 2025

Summary

Returns the IIIF AV Component back into main UV application. Post returning the component some styling was needed to adjust the footer panel and lower tabs.

Related Ticket

#1380

@vercel
Copy link

vercel bot commented Jul 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
universalviewer Ready Ready Preview Comment Aug 28, 2025 5:35pm

@LanieOkorodudu
Copy link
Collaborator

@K8Sewell, Thanks for the PR! I’ve done a round of testing and wanted to share my findings. Hopefully these details are useful and of course, I’d be glad if others could also take a look and confirm.

Layout comparison
I noticed a difference in pixel layout between audio and video when comparing dev and your PR (#1495).

Dev (audio/video viewer):

  • contentLayout: 808px × 630px
  • mainPanel height: 691px
  • centerPanel height: 675px

0penSeadragon manifest Layout
Main panel leftOption: 559px

PR #1495 (audio/video viewer):

  • contentLayout: 808px × 720px
  • mainPanel height: 781px
  • centerPanel height: 765px

0penSeadragon manifest Layout
Main panel leftOption: 781px

screenshots comparison for the layout:
PR#1495 screenshot Layout
PR #1495

dev screenshot Layout
dev

Manifest loading issues

Other issues:
Index tab not loading data: Even after selecting Sort by date or Sort by volume, no info is displayed.
Examples:
https://digital.library.villanova.edu/Collection/vudl:3/IIIF
https://wellcomelibrary.org/iiif/b18035978/manifest
https://wellcomelibrary.org/iiif/b19684915/manifest
https://wellcomelibrary.org/iiif/collection/b19974760
https://wellcomelibrary.org/iiif/collection/b18031511
https://wellcomelibrary.org/iiif/b21274344/manifest
https://wellcomelibrary.org/iiif/b13266330/manifest
https://wellcomelibrary.org/iiif/b19646045/manifest
https://damsssl.llgc.org.uk/iiif/2.0/2373813/manifest.json

  • (screenshot attached).
    PR#1495 screenshot indexTab not loading data:
indexTab no data load

dev screenshot indexTab with loading data
dev-indexTab with data

Additional observations

  • The vertical slider on the contents panel is only visible when hovering, unlike in dev
  • (screenshot attached).
    PR#1495 screenshot slider
slider to move up and down

dev screenshot slider
dev-slider

In this manifest, the images in the content panel differ from dev:
https://biiif-template-zine.vercel.app/index.json

  • (screenshot attached).
    PR#1495 screenshot
PR #1495 contentPanel Pages

dev screenshot
dev contentPanel Pages

Thanks again for working on this PR! I really appreciate the effort, and I’ll be happy to retest once updates are made.
@demiankatz, I’ll leave it to you to decide whether these should be addressed before merging for consistency, or if they can be handled in a follow-up. Thanks also for your time!

@demiankatz
Copy link
Contributor

Thanks for the testing, @LanieOkorodudu -- something strange is definitely going on here. I can think of no reason why integrating the AV component should change anything outside of the AV component, but somehow certain manifests no longer load correctly, and default behaviors of other modules are different. I think further investigation will be needed!

Unfortunately, as I mentioned on the last call, I am currently overwhelmed with work in other projects, so I am probably not going to be able to look more closely at this for some time. I wish I had more bandwidth, but I simply don't at the moment. I will try to revisit this when possible, though!

@K8Sewell
Copy link
Contributor Author

Closing in favor of #1549

@K8Sewell K8Sewell closed this Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants