[VERY WIP] Redux refactor #170
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This definitely looks interesting, but is defo a big change in style. I have feelings about whether I like the more verbose "do this thing", rather than having random other parts of the codebase triggering by themselves based on action firings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move away from
SET_XYZRedux actions and to moreXYZ_HAPPENEDstyle - because firing multiple actions for the same "action" is a bit of a code smell (and it makes the action history harder to parse, and potentially less consistent - and also you have various bits of redux firing actions which conceptually belong in other modules).At this point it's just a trial run, with BroadcastState, which is relatively small.