Skip to content

Updated readme git submodule instructions. #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updated readme git submodule instructions. #77

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dca2da
Updated readme git submodule instructions.
oetseli Apr 20, 2020
aba6d68
Another README update.
oetseli Apr 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions drupal/web/themes/custom/uh_space/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,11 @@ UH theme uses Display suite for most content types/layouting.

_Note:_ Site uses Style Guide fork from here: [email protected]:wunderio/Styleguide.git

1. Checkout git submodules in repository root (Opetustila-esittely/) by running `git submodule update --recursive --remote`. This should add a specific version of UH’s Styleguide to drupal/web/themes/custom/uh_space/lib/uh_styleguide. The commit ref should be ‘37cee5b0a2a754bbbd54f725793b61d0d25a33b7’.
1. If you are pulling submodules for the first time for the project, run `git submodule update --init --recursive --remote` instead.
The reason for the fork is that UH's Styleguide does not have enough contrast in the text colours to pass WCAG 2.1 AA level requirements. It also doesn't work with Webpack's image loading, because background URLs are relative to the styleguide folder. Both of these issues are fixed in the fork.

If the theme doesn't compile without errors in a fresh environment, it's possible that the styleguide submodule has not been initialised correctly so please pay attention to its location in the theme folder and the submodule commit that should be checked out.

1. Checkout git submodules in repository root (Opetustila-esittely/) by running `git submodule update --recursive`. This should add a specific version of UH’s Styleguide to drupal/web/themes/custom/uh_space/lib/uh_styleguide. The checked out commit should be ‘908d40b9be36457057f3b24ba706cc088b8e9c61’.

#### Compiling frontend assets
1. Setting up
Expand Down