feat: new headers and payload ( connection id and interval) #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjaanus
commented
Feb 28, 2025
|
|
||
|
|
||
| @responses.activate | ||
| def test_identification_values_are_passed_in(): |
There was a problem hiding this comment.
This is testing all 3 requests, headers and body
There was a problem hiding this comment.
I remember we had this test added: https://github.com/Unleash/unleash-client-python/pull/342/files#diff-6fd6de24505791fbd1ad578927a8fdd87d15a14b7d194600d68434ddc3e53e00R1038 Are those 2 tests testing similar things?
for more information, see https://pre-commit.ci
kwasniew
reviewed
Feb 28, 2025
UnleashClient/__init__.py
Outdated
| @@ -110,6 +110,7 @@ def __init__( | |||
| self.unleash_app_name = app_name | |||
| self.unleash_environment = environment | |||
| self.unleash_instance_id = instance_id | |||
| self.connection_id = str(uuid.uuid4()) | |||
There was a problem hiding this comment.
we had connection id before. is this code moved?
There was a problem hiding this comment.
Yes, it was initialized only in headers before, now we can use it also in body if needed.
kwasniew
approved these changes
Feb 28, 2025
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request updates
unleash-intervalheader.connectionIdadded to the payload (previously, it only had theunleash-connection-idheader).Metrics updates
unleash-intervalheader.connectionIdadded to the payload (previously, it only had theunleash-connection-idheader).