Do not call Reflection*::setAccessible() in PHP >= 8.1

[W0rma]

Description

Follow-up of #82

Type of change

setAccessible() is only called if PHP < 8.1 is used because it is noop as of PHP 8.1.

This is useful because a deprecation will be triggered in PHP 8.5 if this method is used (see https://wiki.php.net/rfc/deprecations_php_8_5#extreflection_deprecations).

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

• Unit tests
• Spec Tests
• Integration tests / Manual Tests

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[RikudouSage]

I don't think this is necessary, it's simply a noop on newer versions, meaning it's optimized away, while adding an if seems like unnecessary branching, even if simple.

Once support for older versions is dropped, it will be removed completely, until then I think keeping it as is is the best course of actions.

[jdreesen]

But it triggers a deprecation in PHP 8.5.

[RikudouSage]

I see, I added a simple comment and then we can merge it.