-
Notifications
You must be signed in to change notification settings - Fork 64
Feat/streaming disconnect logging #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 17670269762Details
💛 - Coveralls |
LOGGER.error("Error applying streaming state", exc_info=True) | ||
self.load_features() | ||
else: | ||
LOGGER.warning("Ignoring SSE event type: %s", item.event) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if for the unknown events we want warnings or maybe debug instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we may add new event types over time and it's not sth to warn about and pollute logs at this level
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Refactor streaming connector to add disconnect logging and simplify _run.
I changed iteration to
client.all
fromclient.events
to log disconnection warnings. After that_run
had deep nesting. I pulled setup, event handling, error handling, and cleanup into smaller, flatter methods.Example log when disconnected from Edge now looks like this:
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: