feat: make user-agent headers more descriptive #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include in user-agent: - sdk version - ruby version - platform it is running on did not use RUBY_DESCRIPTION as it is a bit too verbose.
Pull Request Test Coverage Report for Build 8245916372Details
💛 - Coveralls |
sighphyre
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
include in user-agent:
did not use RUBY_DESCRIPTION as it is a bit too verbose.
Discussion points
I would recommend getting this change in place, merged and released before #152 is merged. This should allow some sort of telemetry being in place.
I don't believe it is in the user's interest to hide this information from the server. Eventually, maybe, one could consider adding this to the registration phase in the payload as well.