fix: variant stickiness from strategy #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunogois
requested review from
Tymek,
chriswk,
daveleek,
gardleopard,
gastonfournier,
kwasniew,
rarruda and
sighphyre
Pull Request Test Coverage Report for Build 10885454224Details
💛 - Coveralls |
kwasniew
approved these changes
Sep 16, 2024
nunogois
force-pushed
the
chore-variant-custom-strategy-stickiness
branch
from
76c673b to
1403548
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-2644/correctly-resolve-variant-stickiness-from-strategy-in-ruby-sdk
When bumping the client spec in #197 to the latest version I noticed we were not being 100% compliant. The reason for it seemed to be the fact that we're not respecting custom strategy stickiness when resolving variants, as running the spec tests multiple times sometimes returned the wrong variant in those tests.
See:
This PR applies a similar change to the Ruby SDK, bumping the client spec to the latest version.