Skip to content

Conversation

thomasheartman
Copy link
Collaborator

@thomasheartman thomasheartman commented Sep 23, 2024

I wanted to make it clearer that the bundle exec rake release should be run from the main branch because I wasn't sure when I released 5.1.1. I also nested some of the other steps so that the list is separated.

Happy for you to approve or reject this.

@coveralls
Copy link

coveralls commented Sep 23, 2024

Pull Request Test Coverage Report for Build 11103398213

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.374%

Totals Coverage Status
Change from base Build 11100981288: 0.0%
Covered Lines: 433
Relevant Lines: 454

💛 - Coveralls

Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasheartman thomasheartman merged commit caf55da into main Sep 30, 2024
2 checks passed
@thomasheartman thomasheartman deleted the chore/update-release-process branch September 30, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants