Skip to content

Conversation

Drowze
Copy link
Contributor

@Drowze Drowze commented Apr 9, 2025

About the changes

Relax logger gem dependency, so unleash can be used with logger >= 1.6.5.

This should allow using unleash gem with logger 1.7.0 (which was released in 26/March).

Tests seem to pass locally.

Copy link
Collaborator

@rarruda rarruda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt that logger breaks it's API in a minor version change. Nothing particular jumps at me from looking at https://github.com/ruby/logger/releases/tag/v1.7.0 .

If all tests pass as expected, then there is no reason to not relax the dependency version.

@github-project-automation github-project-automation bot moved this from New to Approved PRs in Issues and PRs Apr 9, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 14360315003

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.289%

Totals Coverage Status
Change from base Build 13627587852: 0.0%
Covered Lines: 445
Relevant Lines: 467

💛 - Coveralls

@rarruda rarruda merged commit 8e1e4c6 into Unleash:main Apr 16, 2025
25 checks passed
@github-project-automation github-project-automation bot moved this from Approved PRs to Done in Issues and PRs Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants