Remove user ids strategy 2 #9806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
nunogois
commented
Apr 21, 2025
| .orderBy([ | ||
| { column: 'created_at', order: 'desc' }, | ||
| { column: 'id', order: 'desc' }, | ||
| ]); |
There was a problem hiding this comment.
Scouting. Sometimes events are not returned in a deterministic way. E.g. if two events have the exact same created_at value, sometimes they are returned in a different order. This makes it so we still sort by created_at, but then if it's the same, we fallback to sorting by id.
Perhaps we can consider just sorting by id here and skip sorting by created_at.
nunogois
commented
Apr 22, 2025
| db.runSql( | ||
| ` | ||
| DELETE FROM strategies | ||
| WHERE name = 'userWithId' AND built_in = 1 |
There was a problem hiding this comment.
Unlike e.g.
Here we're deleting the strategy even if it's in use. Based on #9800 it seems like this is what we want to do. However, if it's not, this is something we probably need to change.
There was a problem hiding this comment.
I think we don't want to delete it. The idea is:
- New installations will not receive it
- Old installations requires manual action from the user
gastonfournier
force-pushed
the
remove-user-ids-strategy-2
branch
from
5e0e519 to
a8285c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands on the work done in #9800