-
-
Notifications
You must be signed in to change notification settings - Fork 768
chore: use tokenname instead of username in frontend for api-token creation #9891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
daveleek
merged 5 commits into
main
from
chore/frontend-create-api-token-use-tokenname-not-username
May 8, 2025
Merged
chore: use tokenname instead of username in frontend for api-token creation #9891
daveleek
merged 5 commits into
main
from
chore/frontend-create-api-token-use-tokenname-not-username
May 8, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few questions :D
frontend/src/component/admin/apiToken/ApiTokenForm/useApiTokenForm.ts
Outdated
Show resolved
Hide resolved
frontend/src/component/admin/apiToken/ApiTokenForm/useApiTokenForm.ts
Outdated
Show resolved
Hide resolved
frontend/src/component/admin/apiToken/ApiTokenForm/useApiTokenForm.ts
Outdated
Show resolved
Hide resolved
gastonfournier
approved these changes
May 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…Form.ts Co-authored-by: Gastón Fournier <[email protected]>
gastonfournier
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR: Stop using username and switch to tokenname when creating tokens in the frontend
Splitting up the work on API-Token username->tokenname refactor into separate PRs for separate things. This PR should be able to go to main since we've already introduced tokenname in the API and deprecated username.