Skip to content

chore: use tokenname instead of username in frontend for api-token creation #9891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

daveleek
Copy link
Contributor

@daveleek daveleek commented May 5, 2025

PR: Stop using username and switch to tokenname when creating tokens in the frontend

Splitting up the work on API-Token username->tokenname refactor into separate PRs for separate things. This PR should be able to go to main since we've already introduced tokenname in the API and deprecated username.

Copy link

vercel bot commented May 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview May 6, 2025 8:51am

Copy link
Contributor

github-actions bot commented May 5, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few questions :D

@chriswk chriswk moved this from New to In Progress in Issues and PRs May 6, 2025
Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-project-automation github-project-automation bot moved this from In Progress to Approved PRs in Issues and PRs May 6, 2025
@daveleek daveleek merged commit d15456a into main May 8, 2025
10 checks passed
@daveleek daveleek deleted the chore/frontend-create-api-token-use-tokenname-not-username branch May 8, 2025 07:20
@github-project-automation github-project-automation bot moved this from Approved PRs to Done in Issues and PRs May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants