-
Notifications
You must be signed in to change notification settings - Fork 23
feat: add govulncheck to scan for security issues on PR #1026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
calisio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like the one library that was updated was the crypto library, which after looking is only really used for provider platforms. Hard to check if that had any impact on how they work right now since we haven't used that feature in months/isn't super relevant right now, but something to be aware of if we pick it back up again.
Looks good and functions as expected right now though!
corypride
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests good! Solid implementation, curious about how it will fail currently, I think that it may be too strict as it is currently implemented, and wondering if it would be better if we failed on critical/high vulnerabilities only?
- Create dedicated security-frontend.yml workflow for frontend dependency scanning - Scan for critical and high vulnerabilities only - Send Slack notifications when vulnerabilities are detected - Never block builds, only notify via webhook - Update ESLint workflow to remove duplicate security scanning - Follow gosec implementation pattern from PR #1026
Description of the change
Added automated Go vulnerability scanning to the CI/CD pipeline using the official govulncheck tool. This workflow runs on every pull request that modifies Go code or dependencies and blocks merges if vulnerabilities are detected. Currently there was only one library that needed to be updated along with upping the golang version to 1.23. Not bad.
This enhancement closes a major gap in our Dev Security Ops workflow by ensuring Go dependencies are continuously validated against the latest CVE data from the Go vulnerability database.
Implementation
Screenshot(s)
NA - only ci/cd changes
Additional context
Testing requires only navigating around the site making sure the program tracking pages load properly due to library update.