Ck 7vn/id 507

[CK-7vn]

Description of the change

Adds categorized dropdown reasons for excused and unexcused when taking attendance.

• Related issues: https://app.asana.com/1/1201607307149189/project/1209460078641109/task/1211893266635840?focus=true

Screenshot(s)

Additional context

Please include additional context or information that the reviewer needs to understand the PR. This includes:
Included a bug fix that occured in database/class_events.go where we were only searching for attendance that was linked to the latest schedule rule (event id) for the class.

• If a class schedule was updated (e.g., time changed, days changed), a new "Event" (schedule rule) is often created.
• Any attendance taken under the old schedule was linked to the old Event ID.
• The query Where("event_id = ?", event.ID) was strictly filtering for the current schedule's ID, effectively hiding all attendance records attached to previous versions of the schedule.

So, i just fetched all the event IDs, first retrieve all of the event ids associated with said class_id, query by list, and expand the date range to filter the entirety of the requested month (time period)

[corypride]

Works Well and the tests pass. Good job! Minor adjustment on: class_event.go and we are good. I approve your code, but not related to your PR, but something that copilot flagged are :

High Priority: Race Conditions (Data Loss Risk)
Functions affected:

handleAttendanceChange() - Lines ~200-220
handleReasonChange() - Lines ~225-240
handleNoteChange() - Lines ~195-200

Real-world scenario: User rapidly clicks status → selects reason → types note, and only the last change persists due to race conditions between the three update functions.

Medium Priority: Memory Leaks
Functions affected:

State initialization (lines 94-97) - modifiedRows never gets cleaned up
useEffect (lines 125-144) - Keeps accumulating data from different pages

Real-world scenario: User navigates through 10 pages with 20 users each = 200 entries in modifiedRows object that never get cleared, growing memory usage indefinitely. This gives your coworker concrete examples of exactly where the problems occur and what user behavior triggers them.

[CK-7vn]

Works Well and the tests pass. Good job! Minor adjustment on: class_event.go and we are good. I approve your code, but not related to your PR, but something that copilot flagged are :

High Priority: Race Conditions (Data Loss Risk) Functions affected:

handleAttendanceChange() - Lines ~200-220 handleReasonChange() - Lines ~225-240 handleNoteChange() - Lines ~195-200

Real-world scenario: User rapidly clicks status → selects reason → types note, and only the last change persists due to race conditions between the three update functions.

• React guarantees "prev" is the most recent committed state. Rapid sequential updates are actually batched but each sees the previous update's result. This is Reacts way of handling concurrent updates.

Medium Priority: Memory Leaks Functions affected:

State initialization (lines 94-97) - modifiedRows never gets cleaned up useEffect (lines 125-144) - Keeps accumulating data from different pages

Real-world scenario: User navigates through 10 pages with 20 users each = 200 entries in modifiedRows object that never get cleared, growing memory usage indefinitely. This gives your coworker concrete examples of exactly where the problems occur and what user behavior triggers them.

• This is intentional state preservation, when the component unmounts it actually clears everything, so when a user navigates away, React unmounts and garbage collects all of the state. The pagination accumulation is intentiona in that if a user edits page 1, goes to page 2, edits there, then returns to apge 1, their page 1 edits should be guaranteed to be there, and the submit clears implicitly, On submit changes are posted, and the mutate() revalidates, the user navigates away, and the component unmounts, so it wont actually leak, it preserved unsaved edits across pagination until the user saves or actually navigates away.

[carddev81]

@CK-7vn Tested good and everything persists. I did have a weird error occur that needs attention. When I first select 'Excused' or 'Unexcused' and don't make any selection leaving the default of 'Lockdown' the message 'is required' shows up. Fix this and the github conflicts and is good to go

[carddev81]

On edit of event attendances, when I select a different reason and click save it doesn't keep the changes, fix this and it should be ready to go

[carddev81]

Tested good