Skip to content

Conversation

@CK-7vn
Copy link
Member

@CK-7vn CK-7vn commented Dec 23, 2025

Description of the change

Frontend cleanup that takes care of duplicate React hooks, and console statements, also prettier did some stuff in there too on save..so..

Additional context

  • LoginForm.tsx: Removed a duplicate useEffect that was causing the countdown display logic to run twice on every lockedOutSeconds change. The first effect already handles the timer setup AND display formatting, so the second was redundant.
  • FAQs.tsx: Cleaned up the analytics logging function - removed console statements and simplified to a fire-and-forget pattern since we don't need to handle analytics failures.
  • LibraryViewer.tsx: Removed 3 console statements (debug log + error logs) from bookmark/favorite handlers. The toaster already provides user feedback for errors.
  • BulkUploadModal.tsx: Removed 3 console.error statements from catch blocks. Same reasoning - toasters handle user-facing errors.

Removed the console statements because they can leak internal state and debugging info to users, the duplicate useEffect could cause race conditions, and changed the catch(error) to catch where the error variable wasn't being used, this will help avoid no-unused-vars lint.

@CK-7vn CK-7vn requested a review from a team as a code owner December 23, 2025 19:16
@CK-7vn CK-7vn requested review from corypride and removed request for a team December 23, 2025 19:16
Copy link
Contributor

@corypride corypride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Cleanup.

@CK-7vn CK-7vn force-pushed the CK-7vn/id-556-555-558 branch from 5aa477e to bd8fc30 Compare January 5, 2026 14:53
Copy link
Contributor

@carddev81 carddev81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice clean up

@carddev81 carddev81 merged commit 52d4da9 into main Jan 7, 2026
9 checks passed
@carddev81 carddev81 deleted the CK-7vn/id-556-555-558 branch January 7, 2026 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants