Skip to content

Stations (power spots / dyna /giga) webhook #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Fabio1988
Copy link
Collaborator

@Fabio1988 Fabio1988 commented Feb 8, 2025

Testing required:

  • prometheus
  • webhooks

Still need to think about how this should look like, what we want to send and when (like raid battle time changes, or costume/form)

With the change of battles after max monday e.g. this could be interesting

Also heard that some users (not admins) don't want to use the map, they just rely on webhooks

@Fabio1988 Fabio1988 changed the title Stations webhook Stations(power spots / dyna /giga) webhook Feb 8, 2025
@Fabio1988 Fabio1988 changed the title Stations(power spots / dyna /giga) webhook Stations (power spots / dyna /giga) webhook Feb 8, 2025
@JabLuszko
Copy link

This needs a lot more of if-s into when creating webhook.
Battle time end can change while station end time does not change (like a 'raid hour') - if mon is the same, nothing will happen.
Bread mode can change while mon_id stays the same - Toxtricity Dyna/Giga Max Raid Day.
Form can change... while rest stays the same - Toxtricity again.
If they introduce Costume mons and just throw them 10 am into even and only costume_id changes?

Basically everything needs to be compared, except moves as those seems to be a placeholder

@Fabio1988
Copy link
Collaborator Author

I agree, just a first draft.. will adapt once back from vacation :)
I think it's more about battle details

@Fabio1988 Fabio1988 added the enhancement New feature or request label Feb 12, 2025
@Fabio1988
Copy link
Collaborator Author

Fabio1988 commented Feb 17, 2025

This needs a lot more of if-s into when creating webhook. Battle time end can change while station end time does not change (like a 'raid hour') - if mon is the same, nothing will happen. Bread mode can change while mon_id stays the same - Toxtricity Dyna/Giga Max Raid Day. Form can change... while rest stays the same - Toxtricity again. If they introduce Costume mons and just throw them 10 am into even and only costume_id changes?

Basically everything needs to be compared, except moves as those seems to be a placeholder

Thanks again @JabLuszko , that summary helped a lot.. almost forgot about toxtricity behavior :D

@Fabio1988 Fabio1988 force-pushed the stations-wh branch 5 times, most recently from 8340c77 to 2ef153d Compare February 20, 2025 11:44
@Fabio1988 Fabio1988 force-pushed the stations-wh branch 2 times, most recently from c5c258d to ac5fd99 Compare March 11, 2025 11:32
@Fabio1988 Fabio1988 requested a review from lenisko March 11, 2025 15:11
@Fabio1988 Fabio1988 force-pushed the stations-wh branch 3 times, most recently from 90c33e9 to 0404773 Compare April 14, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants