Cleaning up modules#128
Merged
Merged
Conversation
UnstoppableMango
commented
Jul 12, 2026
UnstoppableMango
commented
Owner
- Begin cleaning up modules
- Revert the gnome stuff
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.
This PR starts consolidating per-user Home Manager configuration into shared modules, while backing out GNOME-specific bits where they don’t apply (e.g., macOS).
Changes:
- Move
aiandgnupgfrom per-user modules into shared, importable modules. - Add
dotfiles.*.enabletoggles forgitandnixtoolchain modules, and enable them per-user. - Introduce an optional
oh-my-zshmodule alongside the existingpreztosetup and update docs accordingly.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| users/erik/gnupg.nix | Makes pinentry conditional (Linux-only) via mkIf. |
| users/erik/default.nix | Switches imports to shared ai/ + gnupg/ modules; enables additional dotfiles toggles. |
| users/erik/ai.nix | Minor formatting-only change. |
| users/erasmussen/gnupg.nix | Removes per-user gnupg module in favor of shared module. |
| users/erasmussen/default.nix | Switches imports to shared ai/ + gnupg/; enables new dotfiles toggles; prunes some packages. |
| toolchain/nix/default.nix | Converts nix toolchain into an enable-gated module (dotfiles.nix.enable). |
| toolchain/git/default.nix | Converts git toolchain into an enable-gated module (dotfiles.git.enable) and adds extra tooling. |
| shells/zsh/oh-my-zsh/default.nix | Adds an enable-gated oh-my-zsh module under dotfiles.zsh.ohMyZsh.enable. |
| shells/zsh/default.nix | Imports both prezto and oh-my-zsh modules. |
| AGENTS.md | Updates module directory documentation (adds ai/, gnupg/, oh-my-zsh note). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+21
to
+24
| user = { | ||
| name = "UnstoppableMango"; | ||
| email = "erik.rasmussen@unmango.dev"; | ||
| }; |
Comment on lines
+8
to
+11
| imports = [ | ||
| ./prezto | ||
| ./oh-my-zsh | ||
| ]; |
| ... | ||
| }: | ||
| { | ||
| options.dotfiles.nix.enable = lib.mkEnableOption "nix Toolchain"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.