Switch to AMD stuff#51
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR switches the hades host configuration from NVIDIA to AMD graphics hardware. The changes update kernel modules, video drivers, and hardware configuration to support AMD GPUs while removing NVIDIA-specific settings.
Key Changes:
- Replaced NVIDIA drivers with AMD GPU drivers (amdgpu)
- Reorganized filesystem mounts and added Docker btrfs bind mount
- Cleaned up unused kernel modules and networking configuration comments
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| hosts/hades/hardware-configuration.nix | Removed unused kernel modules, reordered filesystem mounts, added Docker btrfs bind mount, and cleaned up networking comments |
| hosts/hades/configuration.nix | Added amdgpu kernel module and video driver, commented out NVIDIA hardware configuration, and restructured networking settings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| fileSystems."/nix" = { | ||
| device = "/dev/disk/by-uuid/bcc88460-ce1a-455e-9672-4cb20c25b1bf"; | ||
| fsType = "btrfs"; | ||
| options = [ "subvol=home" ]; | ||
| options = [ "subvol=nix" ]; | ||
| }; | ||
|
|
||
| fileSystems."/nix" = { | ||
| fileSystems."/home" = { | ||
| device = "/dev/disk/by-uuid/bcc88460-ce1a-455e-9672-4cb20c25b1bf"; | ||
| fsType = "btrfs"; | ||
| options = [ "subvol=nix" ]; | ||
| options = [ "subvol=home" ]; | ||
| }; |
There was a problem hiding this comment.
[nitpick] The filesystem definitions for /nix and /home have been swapped in position. While functionally correct, this reordering appears arbitrary and reduces code readability. Consider maintaining a consistent ordering convention (e.g., alphabetical or by mount hierarchy) for filesystem definitions.
|
|
||
| swapDevices = [ ]; | ||
| fileSystems."/var/lib/docker/btrfs" = { | ||
| device = "/home/root/var/lib/docker/btrfs"; |
There was a problem hiding this comment.
The bind mount source path '/home/root/var/lib/docker/btrfs' appears unusual. Typically, 'root' refers to the root user's home directory (/root), not a subdirectory under /home. If this should be the system root directory's path, it should be '/var/lib/docker/btrfs' instead. Verify this path is correct for your intended configuration.
| device = "/home/root/var/lib/docker/btrfs"; | |
| device = "/var/lib/docker/btrfs"; |
No description provided.