Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pdfminer-six dependencies. #417

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pprados
Copy link
Contributor

@pprados pprados commented Apr 3, 2025

Pdfminer has a bug that prevents some PDF files from being read. I've fixed it. A new version is available and should be used in the various projects that depend on this component.

See pdfminer/pdfminer.six#1081

This PR use the version >=20250327

To pass the CI/CD test, I also set the dependencies for python 3.9.

With a minimum version of 3.10, it will be possible to download the latest versions of dependencies.

@pprados pprados force-pushed the pprados/fix-dependencies branch from 5781af5 to 6ce55cc Compare April 3, 2025 11:50
@pprados pprados force-pushed the pprados/fix-dependencies branch 6 times, most recently from a375202 to 2bcc43b Compare April 3, 2025 13:03
@pprados pprados force-pushed the pprados/fix-dependencies branch from 2bcc43b to 3697b6f Compare April 3, 2025 13:10
@pprados pprados marked this pull request as ready for review April 3, 2025 13:20
@pprados pprados force-pushed the pprados/fix-dependencies branch from fdaa931 to d1b9931 Compare April 8, 2025 11:51
@pprados pprados force-pushed the pprados/fix-dependencies branch from d1b9931 to 7142a20 Compare April 9, 2025 11:28
@pprados
Copy link
Contributor Author

pprados commented Apr 11, 2025

@badGarnet

The "Configure AWS credentials" failed => Input required and not supplied: aws-region

make pip-compile invocation fails. Dependencies are not correct for python 3.9. Raising the minimum version to 3.10 would solve the problem. Many dependencies now need 3.10.

The pip-compile approach doesn't handle this properly. An approach using Poetry, for example, would be preferable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant