Skip to content

feat: Migrate Notion source to Connector V2 structure #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 59 commits into from
Jan 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
d618716
Mantain the current v1 file
Oct 9, 2024
5171d9b
finished
Oct 9, 2024
7b93cb6
Black format and changelog add
Oct 10, 2024
2946f52
Fix Makefile issue with lint
Oct 10, 2024
3fc17e8
more fixes
Oct 10, 2024
5d83d7c
restore main files
Oct 10, 2024
40bc3ff
More restored files from main
Oct 10, 2024
1682181
removed useless variable
Oct 10, 2024
cff69aa
Optimized imports
Oct 10, 2024
98e6398
few ruff fixes
Oct 10, 2024
7269c66
last ruff fix
Oct 10, 2024
8b844e0
version updated
Oct 10, 2024
698d715
added notion-client to base.in
Oct 11, 2024
16885f3
remove unused error
Oct 11, 2024
70ee2a5
changed reference
Oct 11, 2024
4bcde56
ruff fix
Oct 11, 2024
4be07b0
Fixed and saving files now
Oct 15, 2024
314a068
Merge branch 'main' into DS-87-notion-source-migration
Oct 15, 2024
9a4147e
addressed
Oct 15, 2024
7c5a5d9
Roman Access Config request addressed
Oct 16, 2024
4ffe9c6
Library type_check done
Oct 16, 2024
1fc45a4
black fix
Oct 16, 2024
f2bc82d
merge main solve conlicts
Oct 16, 2024
04f518f
version file matching
Oct 16, 2024
d43985e
More libraries that needed to be capsulated
Oct 16, 2024
d767980
merge main
Oct 17, 2024
622c05b
Remove leftover comment
Oct 17, 2024
3cbaa50
Multiple PR changes assigned
Oct 18, 2024
2e4f45b
merge main
Oct 18, 2024
7820f09
fixes
Oct 18, 2024
c0c7efe
tries
Oct 18, 2024
f58db9e
More Client
Oct 18, 2024
d5d3339
most done
Oct 18, 2024
0e000b1
missed this
Oct 18, 2024
3cc4086
trying
Oct 18, 2024
f82c0b0
black
Oct 18, 2024
9f02b74
version change
Oct 18, 2024
e4d8118
async client
Oct 18, 2024
2579ace
connector.py updates
Oct 21, 2024
2d4a1d7
autopep8 updates
Oct 21, 2024
b3802b2
merge main
Oct 21, 2024
502aa1a
Roman comments addressed
Oct 22, 2024
abd9f1a
version bump
Oct 22, 2024
d2263ea
params issue
Oct 22, 2024
450aff6
stop ignoring Notion
Oct 23, 2024
3672f3a
merge conflict
Oct 23, 2024
4b1e612
my bad, versions dont match
Oct 23, 2024
047dabf
Async Indexes, making it work
Oct 23, 2024
8705d0b
merge main to feature branch
bryan-unstructured Dec 23, 2024
7550c53
migrate notion source connector to V2
bryan-unstructured Dec 25, 2024
7df67c3
add integration tests for downloading notion database
bryan-unstructured Dec 30, 2024
6bfe4eb
fix expected output files in notion e2e test
bryan-unstructured Dec 30, 2024
dba56b3
make sure the recursive child block getter to point at the next page …
bryan-unstructured Dec 30, 2024
71b0c44
fix syntax
bryan-unstructured Jan 2, 2025
c0f7325
fix block retrieval logic
bryan-unstructured Jan 6, 2025
f99982b
remove unnecessary e2e test for notion connector
bryan-unstructured Jan 6, 2025
f90080a
Add more complex integration test
bryan-unstructured Jan 7, 2025
806d140
update CHANGELOG
bryan-unstructured Jan 7, 2025
5dc64e7
Merge branch 'main' into DS-87-notion-source-migration
bryan-unstructured Jan 8, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Enhancements

* **Migrate Notion Source Connector to V2**
* **Migrate Vectara Destination Connector to v2**
* **Added Redis destination connector**
* **Improved Milvus error handling**
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"directory_structure": [
"1722c3765a0a8082b382ebc2c62d3f4c.html"
]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,330 @@
<table>
<tr>
<th>
Author
</th>
<th>
Email
</th>
<th>
Formula
</th>
<th>
ID
</th>
<th>
Item
</th>
<th>
Phone
</th>
<th>
Priority Level
</th>
<th>
Publication Date
</th>
<th>
Status
</th>
<th>
Tag
</th>
<th>
URL
</th>
<th>
Views
</th>
</tr>
<tr>
<td>
<div>
<span>
<a href='https://lh3.googleusercontent.com/a/AATXAJyU_JkTO5JUkbJ8l_RuIHq4K3KdPghBV0r9U_GU=s100'>
Brian Raymond
</a>
</span>
</div>
</td>
<td>
<div>
[email protected]
</div>
</td>
<td>
<div>
12
</div>
</td>
<td>
<div>
None-4
</div>
</td>
<td>
<div>
test-page4-in-database
</div>
</td>
<td>
<div>
1234567890
</div>
</td>
<td>
<div style='color: gray'>
High
</div>
</td>
<td>
<div>
2025-01-31
</div>
</td>
<td>
<div>
Not started
</div>
</td>
<td>
<div>
<span style='color: purple'>
V1
</span>
<span style='color: yellow'>
V5
</span>
<span style='color: gray'>
V7
</span>
</div>
</td>
<td>
<a href='https://abcde.com'>
https://abcde.com
</a>
</td>
<td>
<div>
6
</div>
</td>
</tr>
<tr>
<td>
<div>
<span>
<a href='https://lh3.googleusercontent.com/a/AATXAJyU_JkTO5JUkbJ8l_RuIHq4K3KdPghBV0r9U_GU=s100'>
Brian Raymond
</a>
</span>
</div>
</td>
<td>
<div>
[email protected]
</div>
</td>
<td>
<div>
90
</div>
</td>
<td>
<div>
None-3
</div>
</td>
<td>
<div>
test-page3-in-database
</div>
</td>
<td>
<div>
1234567890
</div>
</td>
<td>
<div style='color: pink'>
Medium
</div>
</td>
<td>
<div>
2025-01-06
</div>
</td>
<td>
<div style='color: orange'>
In Review
</div>
</td>
<td>
<div>
<span style='color: yellow'>
V5
</span>
<span>
V6
</span>
</div>
</td>
<td>
<a href='https://abcde.com'>
https://abcde.com
</a>
</td>
<td>
<div>
45
</div>
</td>
</tr>
<tr>
<td>
<div>
<span>
<a href='https://lh3.googleusercontent.com/a/AATXAJyU_JkTO5JUkbJ8l_RuIHq4K3KdPghBV0r9U_GU=s100'>
Brian Raymond
</a>
</span>
</div>
</td>
<td>
<div>
[email protected]
</div>
</td>
<td>
<div>
46
</div>
</td>
<td>
<div>
None-2
</div>
</td>
<td>
<div>
test-page2-in-database
</div>
</td>
<td>
<div>
1234567890
</div>
</td>
<td>
<div style='color: blue'>
Low
</div>
</td>
<td>
<div>
2025-01-04
</div>
</td>
<td>
<div style='color: green'>
Done
</div>
</td>
<td>
<div>
<span style='color: purple'>
V1
</span>
<span style='color: orange'>
V2
</span>
<span style='color: brown'>
V4
</span>
</div>
</td>
<td>
<a href='https://abcde.com'>
https://abcde.com
</a>
</td>
<td>
<div>
23
</div>
</td>
</tr>
<tr>
<td>
<div>
<span>
<a href='https://lh3.googleusercontent.com/a/AATXAJyU_JkTO5JUkbJ8l_RuIHq4K3KdPghBV0r9U_GU=s100'>
Brian Raymond
</a>
</span>
</div>
</td>
<td>
<div>
[email protected]
</div>
</td>
<td>
<div>
4
</div>
</td>
<td>
<div>
None-1
</div>
</td>
<td>
<div>
test-page1-in-datab
</div>
</td>
<td>
<div>
1234567890
</div>
</td>
<td>
<div style='color: gray'>
High
</div>
</td>
<td>
<div>
2024-12-01
</div>
</td>
<td>
<div style='color: blue'>
In progress
</div>
</td>
<td>
<div>
<span style='color: purple'>
V1
</span>
<span style='color: green'>
V3
</span>
</div>
</td>
<td>
<a href='https://abcde.com'>
https://abcde.com
</a>
</td>
<td>
<div>
2
</div>
</td>
</tr>
</table>
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
{
"identifier": "1722c3765a0a8082b382ebc2c62d3f4c",
"connector_type": "notion",
"source_identifiers": {
"filename": "1722c3765a0a8082b382ebc2c62d3f4c.html",
"fullpath": "1722c3765a0a8082b382ebc2c62d3f4c.html",
"rel_path": "1722c3765a0a8082b382ebc2c62d3f4c.html"
},
"metadata": {
"url": null,
"version": null,
"record_locator": {
"database_id": "1722c3765a0a8082b382ebc2c62d3f4c"
},
"date_created": "2025-01-05T18:34:00.000Z",
"date_modified": "2025-01-07T19:15:00.000Z",
"date_processed": "1736277913.3980532",
"permissions_data": null,
"filesize_bytes": null
},
"additional_metadata": {
"created_by": {
"id": "118d872b-594c-8171-b46f-00020d10d8b2",
"object": "user"
},
"last_edited_by": {
"id": "118d872b-594c-8171-b46f-00020d10d8b2",
"object": "user"
},
"parent": {
"type": "workspace",
"workspace": true
},
"url": "https://www.notion.so/1722c3765a0a8082b382ebc2c62d3f4c"
},
"reprocess": false,
"local_download_path": "/private/var/folders/h7/n848df9s5yn7ml8rxb61vhyc0000gp/T/tmpxu906ary/1722c3765a0a8082b382ebc2c62d3f4c.html",
"display_name": null
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"directory_structure": [
"1572c3765a0a806299f0dd6999f9e4c7.html"
]
}
Loading
Loading