feat: Improved google drive precheck #376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added test for new precheack Added new fixtures
mateuszkuprowski
added
the
ready for review
Removed test of failure on empty directory
Contributor
|
This is a great improvement over our previous google drive precheck. |
bryan-unstructured
approved these changes
Feb 11, 2025
mateuszkuprowski
deleted the
P6M-1215-google-drive-connector-error-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precheck can now actually verify much more things hence it would be more informative for the user what went wrong when trying to use the connector. It will hopefully catch more cases that would fail at precheck than at runtime.