feat: Add BM25 lexical search support for Weaviate destination#647
Closed
micmarty-deepsense wants to merge 2 commits intomainfrom
Closed
feat: Add BM25 lexical search support for Weaviate destination#647micmarty-deepsense wants to merge 2 commits intomainfrom
micmarty-deepsense wants to merge 2 commits intomainfrom
Conversation
Add support for BM25 keyword search in Weaviate destination connector. Implementation: - Add `enable_lexical_search` flag to WeaviateUploadStagerConfig (default: False) - Configure BM25 scoring in collection schema (b=0.75, k1=1.2) - Enable inverted index with English stopwords for text fields - BM25 always enabled in schema (minimal overhead), flag for API consistency Testing: - Test upload stager config with default and enabled lexical search - Verify BM25 configuration in collection schema - Verify text field configured for lexical search Following AstraDB pattern for consistency. Users opt into hybrid search at query time.
Add enable_lexical_search flag to WeaviateUploadStagerConfig to indicate that the collection is configured for BM25 keyword search. Users must manually configure their Weaviate collection schema with invertedIndexConfig.bm25 settings. See inline documentation for schema example. This flag is declarative - it documents user intent rather than controlling automatic schema creation.
4682138 to
76e9d12
Compare
Contributor
Author
|
Closing: Weaviate's inverted index (indexSearchable=true) already provides BM25 keyword search functionality. No additional flag or configuration needed - it works automatically on text fields. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
enable_lexical_searchflag to Weaviate destination connector to support BM25 keyword search.Changes
enable_lexical_search: boolfield toWeaviateUploadStagerConfig(default: False)Implementation Notes
This is a declarative flag - it indicates that the user has manually configured their Weaviate collection with BM25 support. It does NOT automatically create or modify schemas.
Users must configure their collection schema with:
{ "invertedIndexConfig": { "bm25": { "b": 0.75, "k1": 1.2 }, "stopwords": { "preset": "en" } } }See inline code documentation for full example.
Testing
enable_lexical_search