-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add password with PDF files #3721
Add password with PDF files #3721
Conversation
@plutasnyy can you activate the revue process ? |
Sure! Could you add some unit tests? Ideally some PDF with password that is not extractable with current Please also bump the |
@plutasnyy Done. I add TU. |
@plutasnyy can you test again ? |
@plutasnyy, can you revue the code ? |
Can you approval these workflow ? |
Hi @pprados! Thanks for making this contribution and following up with us. I have some other issues I'm working on right now, but intend to take a look at these changes later this week. |
Super ! I will rebase my PR quickly |
May be can approve this PR, like this I can verify that the PR passes the CI/CD. Otherwise, you must validate each modification I publish. |
@plutasnyy |
@pprados, I already created a PR in |
Add password with PDF files. Must be combined with [PR 3721 in unstructured](Unstructured-IO/unstructured#3721) --------- Co-authored-by: John J <[email protected]>
@Coniferish |
@Coniferish |
@pprados I do not, but I'll see if I can get it updated this week. |
@Coniferish and @christinestraub |
@pprados I'm not understanding this comment. Can you clarify? |
6c1a98b
to
734240b
Compare
@Coniferish |
@Coniferish I will fix |
@Coniferish It's fixed. Can you restart the CI/CD ? |
# Conflicts: # CHANGELOG.md # unstructured/__version__.py
@Coniferish can you revue the code ? thanks |
@pprados, like in the other repo, you can run |
@Coniferish |
@Coniferish |
@Coniferish It's fixed now |
Co-authored-by: John J <[email protected]>
@Coniferish done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @pprados! I know there was a lot of back-and-forth, but any future contributions should go more smoothly now that you're familiar with our checks
Add password with PDF files Must be combined with [PR 392 in unstructured-inference](Unstructured-IO/unstructured-inference#392) --------- Co-authored-by: John J <[email protected]>
Add password with PDF files
Must be combined with PR 392 in unstructured-inference