Ml 384/whitespaces in cct #3747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariannaparzych
requested review from
pawel-kmiecik,
plutasnyy and
pravin-unstructured
pawel-kmiecik
approved these changes
Oct 24, 2024
| ("text", "expected"), | ||
| [ | ||
| ( | ||
| "The dog\rloved the cat, but\t\n the cat\tloved the\n cow", |
Contributor
There was a problem hiding this comment.
I'd add a case when some whitespaces are at the beginning and end of the string
plutasnyy
approved these changes
Oct 24, 2024
temp-adelyn
pushed a commit
to temp-adelyn/unstructured
that referenced
this pull request
Mar 3, 2025
This ticket ensures that CCT metric will not be sensitive to differences in whitespace (including newline). All whitespaces in string are changed to single space `" "` in both GT and PRED before the metric is computed. Additional changes in CHANGELOG due to auto-formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ticket ensures that CCT metric will not be sensitive to differences in whitespace (including newline).
All whitespaces in string are changed to single space
" "in both GT and PRED before the metric is computed.Additional changes in CHANGELOG due to auto-formatting.