fix(ci): Use non-deprecated way of invoking ruff in make tidy
#3825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhdaines
changed the title
make tidymake tidy
cragwolfe
approved these changes
Jan 29, 2025
This reverts commit eaf229f.
christinestraub
approved these changes
Jan 30, 2025
temp-adelyn
pushed a commit
to temp-adelyn/unstructured
that referenced
this pull request
Mar 3, 2025
…ructured-IO#3825) I noticed that `make tidy` wasn't working in my development environment. This happens if you, a developer, forget to follow the specific instructions in `README.md` and install exactly the right versions of the necessary tools, including a *quite old* version of Ruff. This version will nonetheless warn you: warning: `ruff <path>` is deprecated. Use `ruff check <path>` instead. So this fixes that, in order to future-proof and avoid confusion!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
make tidywasn't working in my development environment. This happens if you, a developer, forget to follow the specific instructions inREADME.mdand install exactly the right versions of the necessary tools, including a quite old version of Ruff. This version will nonetheless warn you:So this fixes that, in order to future-proof and avoid confusion!