bugfix/fix ndjson detection #3905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-homan
approved these changes
Feb 5, 2025
scanny
reviewed
Feb 5, 2025
scanny
suggested changes
Feb 5, 2025
Contributor
scanny
left a comment
scanny
left a comment
There was a problem hiding this comment.
I propose moving this lower down, otherwise LGTM.
Let me know and I can approve it then.
Contributor
|
Also @rbiseck3 I'd like to see a test for this. Good chance to fill in for the other possible cases, like when it comes with an asserted content-type. |
Contributor
|
The test suite is well developed, you should be able to do most of it with just adding a case to parameterized tests. |
rbiseck3
force-pushed
the
roman/fix-ndjson-detection
branch
from
ced1e8e to
0159ec4
Compare
rbiseck3
force-pushed
the
roman/fix-ndjson-detection
branch
from
1425726 to
cd1dc47
Compare
rbiseck3
force-pushed
the
roman/fix-ndjson-detection
branch
from
a59df4f to
665d3d5
Compare
temp-adelyn
pushed a commit
to temp-adelyn/unstructured
that referenced
this pull request
Mar 3, 2025
### Description NDJSON files were being detected as JSON due to having the same mime-type. This adds additional logic to skip mime-type based detection if extension is `.ndjson`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NDJSON files were being detected as JSON due to having the same mime-type. This adds additional logic to skip mime-type based detection if extension is
.ndjson