-
Notifications
You must be signed in to change notification settings - Fork 1.1k
⚡️ Speed up function _assign_hash_ids by 34%
#4089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
aseembits93
wants to merge
12
commits into
Unstructured-IO:main
from
aseembits93:codeflash/optimize-_assign_hash_ids-memtfran
Closed
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
5cb28b9
⚡️ Speed up function `_assign_hash_ids` by 34%
codeflash-ai[bot] 136fe26
cleaning up
aseembits93 e3b1911
Merge branch 'main' into codeflash/optimize-_assign_hash_ids-memtfran
aseembits93 fc3e3e5
Merge branch 'main' into codeflash/optimize-_assign_hash_ids-memtfran
aseembits93 ea4a35a
changelog
aseembits93 0e879c7
Merge branch 'main' into codeflash/optimize-_assign_hash_ids-memtfran
aseembits93 35770e0
Update __version__.py
aseembits93 675505c
Merge branch 'main' into codeflash/optimize-_assign_hash_ids-memtfran
aseembits93 bcc492c
Merge branch 'main' into codeflash/optimize-_assign_hash_ids-memtfran
aseembits93 4f8ce2c
changelog version update
aseembits93 42175a3
Update handbook-1p.docx.json
qued 03e48f3
Update handbook-1p.docx.json
qued File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Hash ID Assignment Breaks Page Consistency
The
_assign_hash_idsfunction now assigns sequence numbers based on a global count per page, rather than resetting for each consecutive group of elements on a page. This changes hash ID generation when page numbers are not consecutive, breaking deterministic results and potentially affecting downstream systems.