Skip to content

Conversation

@qued
Copy link
Contributor

@qued qued commented Sep 25, 2025

No description provided.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on October 21

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

seq_on_page_counter = page_seq_counts.get(page_number, 0)
element.id_to_hash(seq_on_page_counter)

page_seq_counts[page_number] = seq_on_page_counter + 1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Hash ID Generation Fails Post-Refactor

The _assign_hash_ids refactor changes sequence numbering from resetting for consecutive page groups to a global counter per page. This breaks deterministic hash ID generation, particularly when elements are not perfectly ordered or processed in fragments, violating the docstring's guarantee.

Fix in Cursor Fix in Web

@qued qued closed this Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant