Fix FutureWarning: Add test to verify bytes are wrapped in BytesIO for read_excel #4213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test ensures that partition_xlsx properly wraps bytes in BytesIO before passing to pd.read_excel(), preventing the deprecation warning mentioned in issue Unstructured-IO#4036.
Author
|
Hi @badGarnet I'd love to get your review and approval |
badGarnet
reviewed
Jan 28, 2026
Comment on lines
+180
to
+184
| with open("example-docs/stanley-cups.xlsx", "rb") as f: | ||
| file_bytes = f.read() | ||
|
|
||
| # Create a BytesIO object from bytes to simulate the scenario | ||
| file_like = io.BytesIO(file_bytes) |
Collaborator
Collaborator
There was a problem hiding this comment.
so I would suggest this PR to actually implement that solution instead of adding this test
Author
There was a problem hiding this comment.
so I would suggest this PR to actually implement that solution instead of adding this test
So, can you let me know what do I have to do?
Addresses reviewer feedback by adding a comment explaining why bytes are wrapped in BytesIO before passing to pd.read_excel to avoid FutureWarning deprecation. References issue Unstructured-IO#4036.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #4036 by ensuring bytes are properly wrapped in BytesIO before passing to
pd.read_excel().Implementation:
The code at line 203 in
unstructured/partition/xlsx.pyalready wraps bytes inBytesIObefore callingpd.read_excel(), which is the correct solution to avoid the FutureWarning deprecation.Changes made:
test_partition_xlsx_no_future_warning_for_bytes) to verify no FutureWarning is raisedThis ensures the fix is documented and tested, preventing future regressions.