docs: name the metric args the docstrings describe - #4453
Open
darkdi wants to merge 1 commit into
Open
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 2 files
Shadow auto-approve: would not auto-approve. Auto-approval skipped because this PR is from an external contributor.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_mean_groupingis public and takesexport_filename, but the docstring calls itexport_namein both the Args block and the line above it, so anyone following the docs passes a kwarg that does not exist. The other one is in_change_bbox_bounds_for_image_size, which came over from super-gradients: the arg was renamed toboxeson the way in and the docstring keptbboxes.No CHANGELOG entry or version bump, since this does not touch core code. Say the word if you want one anyway.