Skip to content

Commit e4fca4e

Browse files
nhortonclaude
andcommitted
fix: use RFC 2119 keywords in review-strategy-matches-criteria-scope
Restructured the requirement to use SHOULD/MAY/MUST NOT explicitly, matching the RFC 2119 style of the other requirements in this schema. The substantive guidance is unchanged: individual is preferred when focus is on each file and the reviewer is unlikely to need to see the other changed files (consulting unchanged project files is explicitly allowed as MAY); matches_together is preferred when changed files need to be looked at alongside each other; and individual is a hard MUST NOT when any criterion is a property of the set of changed files as a whole. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 2d567d8 commit e4fca4e

1 file changed

Lines changed: 12 additions & 10 deletions

File tree

src/deepwork/standard_schemas/job_yml/deepschema.yml

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -77,16 +77,18 @@ requirements:
7777
outside their scope.
7878
7979
review-strategy-matches-criteria-scope: >
80-
Choose the review `strategy` based on whether the criteria need to reason across the
81-
other changed files in the same review set. Use `individual` when the focus is
82-
heavily on each file itself and the reviewer is unlikely to need to look at the other
83-
changed files in order to evaluate this one — the reviewer MAY still consult unchanged
84-
project files for context (imports, references, related code, conventions), and that
85-
does not disqualify `individual`. Use `matches_together` when the changed files are
86-
likely to need to be looked at alongside each other during review — e.g., criteria
87-
about coverage across the set, deduplication, consistency between the files, or any
88-
property of the set as a whole. Picking `individual` for set-level criteria forces
89-
each spawned reviewer to redo the full cross-file scan N times and multiplies latency
80+
The review `strategy` SHOULD match whether the criteria need to reason across the
81+
other changed files in the same review set. `strategy: individual` SHOULD be used
82+
when the focus is on each file itself and the reviewer is unlikely to need to see
83+
the other changed files in order to evaluate this one. A reviewer operating under
84+
`individual` MAY consult unchanged project files for context (imports, references,
85+
related code, conventions); such consultation does NOT require switching to
86+
`matches_together`. `strategy: matches_together` SHOULD be used when the changed
87+
files are likely to need to be looked at alongside each other during review.
88+
`strategy: individual` MUST NOT be used when any criterion is a property of the
89+
set of changed files as a whole (e.g., coverage across the set, deduplication of
90+
the set, cross-file consistency, set-level minimality), because it forces each
91+
spawned reviewer to redo the cross-file scan N times and multiplies latency
9092
without improving review quality.
9193
9294
review-no-redundant-context: >

0 commit comments

Comments
 (0)