feat: In Workflows, only run .deepreview rules against git-changed output files - #342
Merged
Merged
Conversation
The quality gate was treating all file_path outputs as "changed files" for .deepreview matching. This caused reviews to run on unchanged reference files (e.g. key_reference_files in exploration steps). Now intersects output file paths with actual git-changed files before matching .deepreview rules. Step-specific (dynamic) reviews still run against all declared outputs since those are explicitly defined. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
nhorton
force-pushed
the
fix/quality-gate-review-only-required-outputs
branch
from
April 6, 2026 20:20
150cb9d to
de84554
Compare
nhorton
changed the title
…traceability Update requirements to reflect that .deepreview rules are now matched only against git-changed output files, and that dynamic rules still match all outputs. Documents the fallback behavior when get_changed_files fails. Adds traceability comment to the new test. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Reflect that .deepreview rules now match against git-changed output files only, while dynamic rules still match all output files. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Pre-existing issue: requirement 7 read as a descriptive statement without a MUST/SHOULD/MAY keyword, violating the DeepSchema. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
….5.3/4 - Renumber traceability comments (.5.4→.5.5, .5.6→.5.7, .5.7→.5.8) to match spec renumbering - Fix traceability comment format on new test to match project convention - Add test for JOBS-REQ-004.5.3: dynamic rules match all outputs regardless of git status - Add test for JOBS-REQ-004.5.4: get_changed_files failure skips .deepreview matching but dynamic rules still run Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
nhorton
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
file_pathoutputs as "changed files" for.deepreviewrule matchingkey_reference_filesin exploration steps)get_changed_files()(git diff) before.deepreviewmatching — only files that are both step outputs AND actually modified trigger project reviewsTest plan
test_deepreview_rules_skip_unchanged_output_files— unchanged outputs don't trigger.deepreviewrules (JOBS-REQ-004.5.2)test_dynamic_rules_match_all_outputs_regardless_of_git— dynamic rules run on all outputs (JOBS-REQ-004.5.3)test_deepreview_skipped_when_get_changed_files_fails— git failure skips deepreview, dynamic rules unaffected (JOBS-REQ-004.5.4)🤖 Generated with Claude Code