Add missing <cstdint> and <cstddef> headers. #214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug introduced in #188 due to not adding the necessary
<cstdint>
headers when usinginptr_t
.Additionally, as far as I understand the code, the current develop branch exhibits UB or, at best, implementation-defined behavior due to the new error checking introduced in #186. If I only enable, for example, the triad kernel,
goldC
is never written and, therefore, is equal to 0 (the value ofstartC
in theStream.h
header). However, later, the error is calculate as, which results in a division by zero and sets
eC
to NaN. In thecheck
function,eC
is tested against NaN and reports a failing check, althoughvC
is also zero, in which case the result should be marked as correct.I added a (ugly) hotfix, but I'm currently unable to implement a better fix due to time constraints.