Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts - HRRR - Copy previous 7th as a 6th hour #74

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jomey
Copy link
Member

@jomey jomey commented Jan 17, 2025

Sample script on how to modify a missing 6th hour and use the previous hour 7th forecast values.

Sample script on how to modify a missing 6th hour and use the previous
hour 7th forecast values.
Copy link
Member

@jmichellehu jmichellehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions, but looking good. I'll have Alvaro weigh in on any other bits

@jomey
Copy link
Member Author

jomey commented Jan 18, 2025

Generally - Should I add an example to use the 2nd to produce a 1st? Votes?

@jmichellehu
Copy link
Member

My vote is for yes - I think it'd be good to have an example of the 2nd to produce a 1st for completeness.

Unrelated, am I struggling or is the SOURCE_HOUR not used anywhere and is just for reference?

@jomey
Copy link
Member Author

jomey commented Jan 18, 2025

My vote is for yes - I think it'd be good to have an example of the 2nd to produce a 1st for completeness.

Unrelated, am I struggling or is the SOURCE_HOUR not used anywhere and is just for reference?

Not a late Friday struggle :D
That needs to be gone 💥

TODO:

  • Remove unused SOURCE_HOUR variable
  • Fix example header
  • Add an example for the 2nd to the 1st hour

@jomey jomey requested a review from jmichellehu January 23, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants