-
Notifications
You must be signed in to change notification settings - Fork 39
pcap #1096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
pcap #1096
Conversation
|
Could you rebase and solve conflicts with the build system so we can merge? |
nto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A wrapper for an external library should be a standalone module, not included in upipe-modules.
|
Please check examples/Build.mk pcap-deps pcap-deps = upipe_pcap_src doesn't work as I thought it would |
nto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message should be in imperative style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not seem to do anything useful? Shouln't it use a udpsink to send the packets instead of dropping them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it could do something, don't remember how I tested it exactly.
I can remove this dummy exemple if needed.
d5c1740 to
1f1fbcb
Compare
|
pcap depends on bitstream. I suppose right now it will build an empty .so if bitstream is not present |
Such dependency is handled automatically. If |
Co-authored-by: Clément Vasseur <[email protected]>
quarium
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you had the missing documentation and a test?
Gonna look at test and mkdoc |
|
I'm gonna rebase at some point before merging |
Source using pcap files