Skip to content

Conversation

@funman
Copy link
Contributor

@funman funman commented Sep 4, 2025

Source using pcap files

@cmassiot
Copy link
Collaborator

Could you rebase and solve conflicts with the build system so we can merge?

Copy link
Collaborator

@nto nto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A wrapper for an external library should be a standalone module, not included in upipe-modules.

@funman
Copy link
Contributor Author

funman commented Jan 15, 2026

Please check examples/Build.mk pcap-deps

pcap-deps = upipe_pcap_src doesn't work as I thought it would

Copy link
Collaborator

@nto nto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message should be in imperative style.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not seem to do anything useful? Shouln't it use a udpsink to send the packets instead of dropping them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it could do something, don't remember how I tested it exactly.

I can remove this dummy exemple if needed.

@funman funman force-pushed the pcap branch 3 times, most recently from d5c1740 to 1f1fbcb Compare January 16, 2026 15:09
@funman
Copy link
Contributor Author

funman commented Jan 16, 2026

pcap depends on bitstream. I suppose right now it will build an empty .so if bitstream is not present

@nto
Copy link
Collaborator

nto commented Jan 17, 2026

pcap depends on bitstream. I suppose right now it will build an empty .so if bitstream is not present

Such dependency is handled automatically. If bitstream is not present, libupipe_pcap will not be built, and since examples/pcap depends on libupipe_pcap, it won't be built either.

@nto nto requested a review from quarium January 17, 2026 15:36
Co-authored-by: Clément Vasseur <[email protected]>
Copy link
Contributor

@quarium quarium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you had the missing documentation and a test?

@funman
Copy link
Contributor Author

funman commented Feb 3, 2026

Could you had the missing documentation and a test?

Gonna look at test and mkdoc

@funman
Copy link
Contributor Author

funman commented Feb 3, 2026

I'm gonna rebase at some point before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants