Skip to content

test(e2e): introduce e2e tests for S3 integration - #329

Merged
b-rowan merged 3 commits into
UpstreamDataInc:masterfrom
jkuri:e2e
Aug 9, 2025
Merged

test(e2e): introduce e2e tests for S3 integration#329
b-rowan merged 3 commits into
UpstreamDataInc:masterfrom
jkuri:e2e

Conversation

@jkuri

@jkuri jkuri commented Aug 9, 2025

Copy link
Copy Markdown
Collaborator

Hi,

I made e2e tests for S3 integration, you can try running it with:

poetry run pytest -v -s e2e/

The tests include;

  • creating bucket on MinIO
  • uploading file to goosebit and checking if it exists on S3
  • run software update on device with swupdate installed

b-rowan
b-rowan previously approved these changes Aug 9, 2025

@b-rowan b-rowan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. This looks amazing, I'm not even sure I'm fully qualified to review this. Only real question I have is if it would make sense to move this to e2e/s3/ or something like that, since this is testing with an S3 bucket instead of local filesystem storage, but that's likely unimportant.

Comment thread e2e/Dockerfile Outdated
@b-rowan
b-rowan merged commit 25ab8d6 into UpstreamDataInc:master Aug 9, 2025
6 checks passed
@jkuri

jkuri commented Aug 9, 2025

Copy link
Copy Markdown
Collaborator Author

Yes, in our company we will be batch updating > 1k remote applicances using goosebit with s3 integration and we need to be sure that it works, that's why I put some effort into e2e tests.

I moved files to e2e/s3 as you suggested as additional e2e tests may come in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants