test(e2e): introduce e2e tests for S3 integration - #329
Merged
Conversation
b-rowan
previously approved these changes
Aug 9, 2025
b-rowan
left a comment
Member
There was a problem hiding this comment.
Wow. This looks amazing, I'm not even sure I'm fully qualified to review this. Only real question I have is if it would make sense to move this to e2e/s3/ or something like that, since this is testing with an S3 bucket instead of local filesystem storage, but that's likely unimportant.
b-rowan
approved these changes
Aug 9, 2025
Collaborator
Author
|
Yes, in our company we will be batch updating > 1k remote applicances using I moved files to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I made e2e tests for S3 integration, you can try running it with:
The tests include;
swupdateinstalled