Skip to content

bug(regression): fix software version sorting - #367

Merged
b-rowan merged 1 commit into
masterfrom
fix-version-sorting
Sep 10, 2025
Merged

bug(regression): fix software version sorting#367
b-rowan merged 1 commit into
masterfrom
fix-version-sorting

Conversation

@b-rowan

@b-rowan b-rowan commented Sep 9, 2025

Copy link
Copy Markdown
Member

No description provided.

@b-rowan
b-rowan requested a review from easybe September 9, 2025 21:49
@easybe

easybe commented Sep 10, 2025

Copy link
Copy Markdown
Collaborator

Sorting the software table seems to work fine now.

Would it be possibe to do the same for the devices table?

Screenshot from 2025-09-10 08-43-58

Note that before, sorting by "Installed Software" did not work correctly either, but, now we also have the option to sort by "Target Software".

@b-rowan

b-rowan commented Sep 10, 2025

Copy link
Copy Markdown
Member Author

I think the concern with this was that there tends to be a lot more devices, so in applications with 1000s of devices I think the in-memory sorting could be an issue, but if you think it's OK I'll implement it.

@easybe

easybe commented Sep 10, 2025

Copy link
Copy Markdown
Collaborator

I think the concern with this was that there tends to be a lot more devices, so in applications with 1000s of devices I think the in-memory sorting could be an issue, but if you think it's OK I'll implement it.

I see. Let's go without in that case (for now).

@b-rowan
b-rowan merged commit 47fb73a into master Sep 10, 2025
9 checks passed
@b-rowan
b-rowan deleted the fix-version-sorting branch September 10, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants