feat: add new endpoints, one for tax settings and one to list customer payment methods, fix CI, payment_intent.latest_charge#5
Merged
tferrerm merged 11 commits intoNov 3, 2025
Conversation
…r payment methods
tferrerm
commented
Aug 29, 2025
tferrerm
changed the title
yoshka88
approved these changes
Sep 29, 2025
yoshka88
left a comment
yoshka88
left a comment
There was a problem hiding this comment.
Somehow missed this PR in August.
✅ perfect addition to stripe mock, no objection codewise
|
Ah, yeah, I broke those tests for Checkout::Session. Will fix |
…customers-payment-methods-support
Author
|
@yoshka88 feel free to merge this one! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main objective of this PR was to silence the warnings printed all over the tests:
Stripe::Tax::Settings.retrieveStripe::Customer.list_payment_methodsReplacepayment_intent.chargesarray withpayment_intent.latest_chargejust as Stripe didFix CI which was brokenAdd dependency that might silence some warnings in Ruby 3.3 and beyondUpdate: many of these changes have been included into Galina's last merging from upstream. CI is also broken in master branch and the same tests fail.
References:
stripe-ruby-mock#917
stripe-ruby-mock#920
stripe-ruby-mock#925
stripe-ruby-mock#929
Once merged, we should update the gem in all Gemfiles.