Skip to content

Fix flash message#386

Merged
lwesterhof merged 4 commits intodevelopmentfrom
fix-flash-message
Jan 28, 2025
Merged

Fix flash message#386
lwesterhof merged 4 commits intodevelopmentfrom
fix-flash-message

Conversation

@claudisa-uu
Copy link
Contributor

In issue YDA-6118, the error message that appeared when publication terms failed to save was not rendered properly (only appeared as plain text without the red box). We figured that the issue was the way we check for the message type as in Jinja sameas compares memory addresses, not strings.

@claudisa-uu claudisa-uu marked this pull request as ready for review January 22, 2025 13:59
@claudisa-uu claudisa-uu changed the title Fix flash message [draft] Fix flash message Jan 22, 2025
@lwesterhof lwesterhof self-requested a review January 28, 2025 07:49
Copy link
Member

@lwesterhof lwesterhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, LGTM!

@lwesterhof lwesterhof merged commit 3a0d4be into development Jan 28, 2025
10 checks passed
@lwesterhof lwesterhof deleted the fix-flash-message branch January 28, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants