Skip to content

Yda 6068 add csv output to troubleshoot tool #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 22 commits into
base: development
Choose a base branch
from

Conversation

FuHsinyu
Copy link
Member

@FuHsinyu FuHsinyu commented Mar 31, 2025

  1. Run in human readable output (by default):
    python3 troubleshoot-published-data.py -m human or python3 troubleshoot-published-data.py
  2. Run in CSV output:
    python3 troubleshoot-published-data.py -m csv

Documentation update: UtrechtUniversity/yoda#551

@FuHsinyu

This comment was marked as outdated.

@FuHsinyu

This comment was marked as outdated.

@stsnel stsnel self-requested a review March 31, 2025 15:23
@FuHsinyu FuHsinyu marked this pull request as ready for review April 7, 2025 13:12
@FuHsinyu
Copy link
Member Author

FuHsinyu commented Apr 7, 2025

Currently, there is an error when you run the troubleshooting tool with python3, because we upgraded python2 to python 3. See the code local_data_uni = local_data.decode("utf-8"). A workaround is to use local_data_uni = local_data#.decode("utf-8") in publication-troubleshoot.py

@FuHsinyu
Copy link
Member Author

FuHsinyu commented Apr 7, 2025

Currently, a potential improvement is that: when outputting a failed package with a failed reason (e.g, missing AVUs), in human mode, the reason will be displayed at the top of the output. Rather, I wonder if it be nice to have the reason combined with the package output. Let me know what you think.
e.g,
Troubleshooting package No.1:
Missing AVU found...
Troubleshooting package No.2:
MIssing landing page.

Results for: NO.1
Package FAILED one or more tests:
Schema Check: Pass
Missing AVUs Check: Fail
Unexpected AVUs Check: Pass
Version DOI Check: Fail
Landing Page Check: Pass
Combi JSON Check: Pass

Results for: NO.2
Package FAILED one or more tests:
Schema Check: Pass
Missing AVUs Check: Pass
Unexpected AVUs Check: Pass
Version DOI Check: Fail
Landing Page Check: Fail
Combi JSON Check: Pass

Copy link
Member

@stsnel stsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good in general 👍! Can you remove trailing whitespace in troubleshoot_data.r and have a look at the comment above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants