Skip to content

yda-6303 bug fix for troubleshooting tool #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

yda-6303 bug fix for troubleshooting tool #568

wants to merge 2 commits into from

Conversation

FuHsinyu
Copy link
Member

@FuHsinyu FuHsinyu commented Apr 8, 2025

No description provided.

@FuHsinyu FuHsinyu marked this pull request as ready for review April 8, 2025 08:03
stsnel
stsnel reviewed Apr 9, 2025
View reviewed changes
Copy link
Member

@stsnel stsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good 👍 Can you please add a comment to the try/except block that explains the reason for checking the type returned by data_object.read here (i.e. portability of this code to 1.9 branch).?

@FuHsinyu
Copy link
Member Author

The code looks good 👍 Can you please add a comment to the try/except block that explains the reason for checking the type returned by data_object.read here (i.e. portability of this code to 1.9 branch).?

Yup, just added the update which tested successfully for 1.9.5 (centOS7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsnel stsnel stsnel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FuHsinyu @stsnel