Enhancements to INetworkManager Interface and NetworkManager Class #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `_updateParameters` to allow toggling `handleRefreshToken` for individual requests. - Enhanced the `send` method to support optional `handleRefreshToken` parameter. - Ensured backward compatibility by defaulting to existing behavior when `handleRefreshToken` is not provided.
- Updated `_updateParameters` to allow toggling `handleRefreshToken` for individual requests. - Enhanced the `send` method to support optional `handleRefreshToken` parameter. - Ensured backward compatibility by defaulting to existing behavior when `handleRefreshToken` is not provided.
- Updated INetworkManager to include a generic parameter for custom parameters. - Modified NetworkManager and its mixins to handle custom parameters. - Enhanced type safety across the network manager implementation. - Updated example usage in json_place_holder_view_model.dart. - Adjusted caching and error handling logic to accommodate new parameterization.
…ptional-parameters-and-refresh-token
…workManagerParameters
…nsistent type parameters
…ameters across tests
Contributor
Author
|
Migration Note: This PR introduces a breaking change by requiring a second generic parameter
|
VB10
reviewed
May 16, 2025
Owner
VB10
left a comment
VB10
left a comment
There was a problem hiding this comment.
@ahmtydn thank you for some coding fixes but i think this changes getting a lot of migration for couple of business project and third param it not useless you can manage extra param in your application side.
Vexana just only handle about network logic.
Thanks again but not need now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces several changes and improvements to the Vexana library. Below is a summary of the modifications:
Changes
Pfor enhanced flexibility.Pand added methods for handling custom parameters and refresh tokens.NetworkManagerOperation,NetworkManagerCache,NetworkManagerResponse, and other mixins to support the new generic parameterP.INetworkManagerinterface andNetworkManagerclass changes.Bug Fixes
NetworkManagerCache.NetworkManagerErrorInterceptorrelated to unauthorized requests.Breaking Changes
INetworkManagerinterface now requires two generic parameters.NetworkManagerneed to be updated to include the second generic parameter.Additional Notes
INetworkManager<E, P>interface.Checklist