Fix interrupts being ignored / Crystal City #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
callsop
commented
May 14, 2025
callsop
commented
- fix ignored interrupts
- fixes game Crystal City
- remove all the duplicated definitions for interrupts
- replace magic numbers with constants
Contributor
Author
|
Although this works, its not quite right need to investigate this further. |
Contributor
|
Crystal City seems good however Contras no longer works. Chambers runs too fast again. Max 10 still works. Koronis don't know if it works or not I may just no know how to work it. |
Contributor
Author
|
Yes I will make further changes for this. Hence the test case I wrote to check changes. |
callsop
force-pushed
the
fix-interrupts-crystal
branch
from
2dbe879 to
32c8a41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.