reduce usage of MAX_LOAD_STRING #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Unsure about conflicts resolution for this so leaving it |
…ving name, catalog id, and description
… _acia_ cartridges removed loading of configuration section from the cartridge name resource of the string table
ChetSimpson
force-pushed
the
cs/vcc/reduce-usage-of-maxloadstirng
branch
from
dea113e to
904f889
Compare
Contributor
Author
I expected them. Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the use of fixed sized character strings used to store text loaded from the string table resource and thus reduces the use of
MAX_LOADSTRING.LoadStringto::vcc::utils::load_stringwhen retrieving name, catalog id, and description in cartridges.